projects / fwx / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 7b02629)
Fix the charset master
authorDavid Kerkeslager <kerkeslager@gmail.com>
Sat, 14 Dec 2019 04:40:47 +0000 (23:40 -0500)
committerDavid Kerkeslager <kerkeslager@gmail.com>
Sat, 14 Dec 2019 04:40:47 +0000 (23:40 -0500)
src/fwx/__init__.py patch | blob | history
src/test_fwx.py patch | blob | history

diff --git a/src/fwx/__init__.py b/src/fwx/__init__.py
index 6ee7541..2cbe707 100644 (file)
--- a/src/fwx/__init__.py
+++ b/src/fwx/__init__.py
@@ -174,7 +174,7 @@ class HTMLResponse(Response):
         return super().__new__(
             cls,
             content,
-            content_type='text/html',
+            content_type='text/html; charset=utf-8',
             **kwargs,
         )
 
@@ -186,7 +186,7 @@ class JSONResponse(Response):
         self = super().__new__(
             cls,
             content=json.dumps(content_json),
-            content_type='application/json',
+            content_type='application/json; charset=utf-8',
             **kwargs,
         )
         self.content_json = content_json
@@ -199,7 +199,7 @@ class TextResponse(Response):
         return super().__new__(
             cls,
             content,
-            content_type='text/plain',
+            content_type='text/plain; charset=utf-8',
             **kwargs,
         )
 
diff --git a/src/test_fwx.py b/src/test_fwx.py
index 97a7f74..0887039 100644 (file)
--- a/src/test_fwx.py
+++ b/src/test_fwx.py
@@ -41,14 +41,14 @@ class ResponseTests(unittest.TestCase):
 
     def test_headers(self):
         response = fwx.Response(
-            content_type='text/plain',
+            content_type='text/plain; charset=utf-8',
             content='Hello, world\n',
         )
 
         self.assertEqual(
             response.headers,
             (
-                ('Content-Type', 'text/plain'),
+                ('Content-Type', 'text/plain; charset=utf-8'),
                 ('X-Content-Type-Options', 'nosniff'),
             ),
         )
@@ -56,12 +56,12 @@ class ResponseTests(unittest.TestCase):
 class HTMLResponseTests(unittest.TestCase):
     def test_sets_content_type(self):
         response = fwx.HTMLResponse('<html><body>Hello, world</body></html>')
-        self.assertEqual(response.content_type, 'text/html')
+        self.assertEqual(response.content_type, 'text/html; charset=utf-8')
 
 class JSONResponseTests(unittest.TestCase):
     def test_sets_content_type(self):
         response = fwx.JSONResponse({ 'foo': 'bar', 'baz': 42 })
-        self.assertEqual(response.content_type, 'application/json')
+        self.assertEqual(response.content_type, 'application/json; charset=utf-8')
 
     def test_sets_content(self):
         response = fwx.JSONResponse({ 'foo': 'bar', 'baz': 42 })
@@ -74,7 +74,7 @@ class JSONResponseTests(unittest.TestCase):
 class TextResponseTests(unittest.TestCase):
     def test_sets_content_type(self):
         response = fwx.TextResponse('Hello, world\n')
-        self.assertEqual(response.content_type, 'text/plain')
+        self.assertEqual(response.content_type, 'text/plain; charset=utf-8')
 
 class RedirectResponse(unittest.TestCase):
     def test_takes_location_as_positional_argument(self):
A minimal Python web framework